fix python 2.x style code for python 3.x#19358
Open
katietz wants to merge 7 commits intoemscripten-core:mainfrom
Open
fix python 2.x style code for python 3.x#19358katietz wants to merge 7 commits intoemscripten-core:mainfrom
katietz wants to merge 7 commits intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
May 15, 2023
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Almost all of these files are under "third_party" directories which, I general, we don't want to patch like this.
sbc100
reviewed
May 15, 2023
sbc100
reviewed
May 16, 2023
|
|
||
| strInfo = {} | ||
| for propName in propNames: | ||
| strInfoPath = u'\\StringFileInfo\\%04X%04X\\%s' % (lang, codepage, propName) |
Collaborator
There was a problem hiding this comment.
This file needs to run on python2, so maybe this should be reverted?
Collaborator
There was a problem hiding this comment.
This still needs to be reverted I think
sbc100
reviewed
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.