Create launcher scripts as part of bootstrap.py#20433
Create launcher scripts as part of bootstrap.py#20433sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
bootstrap.py#20433Conversation
|
I'll probably wait until the next release before landing this so that folks are already used to running the bootstrap script. |
I'll jump bump up my feature request for adding a git hook (at least optional). I can totally see myself regularly forgetting to run bootstrap.py when switching branches and wondering why stuff breaks locally. Bisect is another case where, as you mentioned yourself, it would be immensely useful. |
Yeah.. how about |
Sure, sgtm. |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm, good ideas to keep emcc files for now, and to land this only after the next release, and to have a git hook option.
sbc100
force-pushed
the
bootstrap2
branch
2 times, most recently
from
2014f82 to
358721a
Compare
Followup to emscripten-core#19736 This allows us to do is delete all the checked in launcher files from the top level directory. This in turn means we can create just the `.bat` file launchers on windows and just the `.sh` launchers on non-windows. The is a small step towards having a much cleaner top-level directory. Note that I have left the launchers for emcc checked-in (at least for the transition period) so that new users will see the error message and know to run `bootstrap.py` if they run `emcc` on a fresh checkout.
3 participants
Followup to #19736
This allows us to do is delete all the checked in launcher files from the top level directory. This in turn means we can create just the
.batfile launchers on windows and just the.shlaunchers on non-windows. The is a small step towards having a much cleaner top-level directory.Note that I have left the launchers for emcc checked-in (at least for the transition period) so that new users will see the error message and know to run
bootstrap.pyif they runemccon a fresh checkout.