Conversation
47adffc to
666eeee
Compare
| $pauseMainLoop: 'Browser.mainLoop.pause', | ||
| $resumeMainLoop: 'Browser.mainLoop.resume', | ||
| $getUserMedia: 'Browser.getUserMedia', | ||
| $createContext: 'Browser.createContext', |
There was a problem hiding this comment.
Do we automatically add helpful messages in debug builds for these? I am guessing maybe no, since I'm not sure we have a list that includes these particular functions atm. We have that for other things where the error message tells the user exactly what to do, which could be good here as well.
There was a problem hiding this comment.
Yes, we do. In debug builds if you try to call Module['anyLibraryFuncAtAll'] you will see this one of these two errors:
emscripten/src/runtime_debug.js
Line 65 in 04a0cad
emscripten/src/runtime_debug.js
Line 92 in 04a0cad
I locally verified this was the case with these changes, but we do have tests for that too.
kripken
left a comment
There was a problem hiding this comment.
Sounds good.
None of the code size tests measure this? Maybe we don't use browser code there.
Yeah we don't have any code size measurement for things like |
666eeee to
eb0cf9f
Compare
No description provided.