Fix wrong return values for wgpuBufferGetMapState #22301
Conversation
|
Hello! |
|
@kainino0x would it be reasonable to have a test for this? |
|
In principle it would be good to do that (not just for these tables but also for the codegen-time tables), however our focus is currently on Dawn's fork of these bindings, and we've already obsoleted this problem there by autogenerating all of these tables so they can't get out of sync. On the Emscripten side, things should hopefully not break too quickly since we're not actively developing Emscripten's version right now. When we unfork and port the work from Dawn back into Emscripten, we'll definitely try to avoid reintroducing the manually-maintained tables (though I don't know precisely how we'll do it yet). |
| 'mapped': 2, | ||
| 'unmapped': 1, | ||
| 'pending': 2, | ||
| 'mapped': 3, |
There was a problem hiding this comment.
It looks like Int_CompilationMessageType might also be off by one:
system/include/webgpu/webgpu.h: WGPUCompilationMessageType_Error = 0x00000001,
system/include/webgpu/webgpu.h: WGPUCompilationMessageType_Warning = 0x00000002,
system/include/webgpu/webgpu.h: WGPUCompilationMessageType_Info = 0x00000003,
How did this stuff ever work? Or is it just not tested?
There was a problem hiding this comment.
A lot of these are pretty niche and most applications don't use them. It probably broke at some point when we updated the header (which shifted the numbers) but no one was using it.
5 participants
Fixes #22300.