Fix STACK_OVERFLOW_CHECK + WASM_WORKERS #22756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Split out from #22721 |
We we not calling `writeStackCookie()` in the right place which means that `checkStackCookie()` would always fail in wasm workers.
sbc100
force-pushed
the
wasm_worker_stack_check
branch
from
936667d to
fef8101
Compare
kripken
reviewed
Oct 17, 2024
| #endif | ||
|
|
||
| #if STACK_OVERFLOW_CHECK | ||
| stackCheckInit(); |
Member
There was a problem hiding this comment.
This code both moved and lost the condition if (!pthread) - do we not need that?
Collaborator
Author
There was a problem hiding this comment.
We already have early return for if (ENVIRONMENT_IS_PTHREAD) and if (ENVIRONMENT_IS_WASM_WORKER) so by the time we get here know were the main runtime thread.
juj
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We we not calling
writeStackCookie()in the right place which means thatcheckStackCookie()would always fail in wasm workers.Required for #22721