Fix emscan-deps to handle emscripten args #24506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make this work I extracted the command line handling code into tools/cmdline.py. This should also help for creating emld, the standalone linker. Without this change the test fails with: ``` Error while scanning dependencies for /usr/local/google/home/sbc/dev/wasm/emscripten/test/cmake/cxx20/main.cpp: error: unknown argument: '-sUSE_SDL' ``` Fixes: emscripten-core#24454, emscripten-core#24410
dschuff
approved these changes
Jun 6, 2025
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
This refactoring looks good. It's a bummer that we have these -s args at compile time though. I assume port-related ones like -sUSE_SDL could eventually be transitioned to -i flags or something. Are there others that are really intractable?
Lukasdoe
pushed a commit
to Lukasdoe/emscripten
that referenced
this pull request
Jun 19, 2025
In order to make this work I extracted the command line handling code into tools/cmdline.py. This should also help for creating emld, the standalone linker. Without this change the test fails with: ``` Error while scanning dependencies for /usr/local/google/home/sbc/dev/wasm/emscripten/test/cmake/cxx20/main.cpp: error: unknown argument: '-sUSE_SDL' ``` The code in the new cmdline.py file is just ~600 lines that was previously in emcc.py, completely unmodified. Fixes: emscripten-core#24454, emscripten-core#24410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this work I extracted the command line handling
code into tools/cmdline.py. This should also help for creating emld,
the standalone linker.
Without this change the test fails with:
The code in the new cmdline.py file is just ~600 lines that was previously
in emcc.py, completely unmodified.
Fixes: #24454, #24410