Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 29, 2025

No description provided.

@sbc100 sbc100 requested a review from kripken October 29, 2025 19:01
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Walkthrough

This pull request removes experimental WebAssembly feature flags from V8 test invocations across two test files. The changes eliminate --experimental-wasm-simd, --experimental-wasm-extended-const, and --experimental-wasm-stack-switching flags from test decorators and test methods.

Changes

Cohort / File(s) Summary
Experimental flag removals
test/test_core.py, test/test_other.py
Removed injection of experimental WebAssembly flags (--experimental-wasm-simd, --experimental-wasm-extended-const, --experimental-wasm-stack-switching) from V8 test arguments in the wasm_simd decorator and in test_unsafe_optimizations and test_jspi_code_size test methods

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes follow a consistent removal pattern with no new logic introduced
  • No complex dependencies or behavioral modifications to assess

Poem

🐰 Away with flags experimental we go,
V8's test args, now lean and low,
SIMD, const, and stack-switch cease,
Our tests run lighter, at peace.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "[test] Remove no-longer-needed v8 flags. NFC" directly and accurately describes the primary objective of the changeset. The PR removes three experimental v8 flags (--experimental-wasm-simd, --experimental-wasm-extended-const, and --experimental-wasm-stack-switching) from test files, which aligns perfectly with the stated title. The title is concise, specific, and clearly conveys that this is a test-related cleanup of no longer needed flags, and the "NFC" annotation appropriately indicates no functional change. A developer scanning the repository history would immediately understand the purpose of this pull request.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3bd469 and c6568d2.

📒 Files selected for processing (2)
  • test/test_core.py (0 hunks)
  • test/test_other.py (0 hunks)
💤 Files with no reviewable changes (2)
  • test/test_core.py
  • test/test_other.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Codesize Checks
  • GitHub Check: build-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 29, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sbc100 sbc100 merged commit ad27b57 into emscripten-core:main Oct 29, 2025
35 checks passed
@sbc100 sbc100 deleted the remove_v8_flags branch October 29, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants