[test] Split browser-specific code into browser_common.py. NFC #25728
+957
−915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_test_common
branch
from
a38bf84 to
cc918b1
Compare
Collaborator
|
Looks good, though please after #25704 lands? |
sbc100
force-pushed
the
browser_test_common
branch
from
cc918b1 to
dc81b2b
Compare
common.py was getting pretty huge and about 900 lines of it was browser-test specific stuff.
sbc100
force-pushed
the
browser_test_common
branch
from
dc81b2b to
7301fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.py was getting pretty huge and about 900 lines of it was browser-test specific stuff.