Remove use of global event object from libhtml5.js. NFC
#25827
Merged
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Nov 19, 2025
dschuff
reviewed
Nov 19, 2025
| Browser.calculateMouseEvent(event); | ||
|
|
||
| // cross-browser wheel delta | ||
| var e = window.event || event; // old IE support |
Member
There was a problem hiding this comment.
Also it says `// old IE support' so the reasoning seems pretty sound.
This fallback to `windows.event` goes all the way back to the original implementation in 2014: 96895e6. According to AI the reason for this code was likely IE support: """ This common JavaScript pattern used in legacy code to ensure cross-browser compatibility for accessing the event object. This was necessary because older versions of Microsoft Internet Explorer (IE) handled events differently than the standards-compliant browsers. """
sbc100
force-pushed
the
remove_global_event_usage
branch
from
4049a0e to
62e77d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fallback to
windows.eventgoes all the way back to the original implementation in 2014: 96895e6.According to AI the reason for this code was likely IE support:
"""
This common JavaScript pattern used in legacy code to ensure cross-browser compatibility for accessing the event object. This was necessary because older versions of Microsoft Internet Explorer (IE) handled events differently than the standards-compliant browsers.
"""