Skip to content

[wasm64] Fix pointer math in glTransformFeedbackVaryings() and glGetUniformIndices() #25844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
+2 −2
Merged

[wasm64] Fix pointer math in glTransformFeedbackVaryings() and glGetUniformIndices() #25844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/libwebgl2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ var LibraryWebGL2 = {
program = GL.programs[program];
var vars = [];
for (var i = 0; i < count; i++)
vars.push(UTF8ToString({{{ makeGetValue('varyings', 'i*4', 'i32') }}}));
vars.push(UTF8ToString({{{ makeGetValue('varyings', 'i*' + POINTER_SIZE, '*') }}}));
Copy link
Collaborator

@sbc100 sbc100 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that cover these functions?

Copy link
Contributor Author

@gkv311 gkv311 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not any inside test folder as far as I can see.

Copy link
Collaborator

@sbc100 sbc100 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thats no bad. No testing here. We should certainly add some, but I don't think we need to block this change on that.


GLctx.transformFeedbackVaryings(program, vars, bufferMode);
},
Expand Down Expand Up @@ -519,7 +519,7 @@ var LibraryWebGL2 = {
program = GL.programs[program];
var names = [];
for (var i = 0; i < uniformCount; i++)
names.push(UTF8ToString({{{ makeGetValue('uniformNames', 'i*4', 'i32') }}}));
names.push(UTF8ToString({{{ makeGetValue('uniformNames', 'i*' + POINTER_SIZE, '*') }}}));

var result = GLctx.getUniformIndices(program, names);
if (!result) return; // GL spec: If an error is generated, nothing is written out to uniformIndices.
Expand Down