Avoid uses of ?. in locations that are not Babeled #25880
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8.12.0esr pass browser tests.
sbc100
approved these changes
Nov 27, 2025
src/modularize.js
Outdated
| // In EXPORT_ES6 mode we can just use 'import.meta.url'. | ||
| #if MIN_FIREFOX_VERSION < 74 | ||
| // This modularize.js script is not Babeled, so manually adapt for old browsers. | ||
| var _scriptName = typeof globalThis !== 'undefined' && globalThis.document && globalThis.document.currentScript ? globalThis.document.currentScript.src : undefined; |
Collaborator
There was a problem hiding this comment.
I think its shorter to write typeof document != 'undefined' && document.currentScript ? ...
src/modularize.js
Outdated
| // When MODULARIZE this JS may be executed later, | ||
| // after document.currentScript is gone, so we save it. | ||
| // In EXPORT_ES6 mode we can just use 'import.meta.url'. | ||
| #if MIN_FIREFOX_VERSION < 74 |
Collaborator
There was a problem hiding this comment.
So we not support targeting older browsers that also don't support the ?. notation?
How about including LEGACY_VM_SUPPORT here?
Collaborator
Author
There was a problem hiding this comment.
So we not support targeting older browsers that also don't support the
?.notation?
Can you rephrase?
How about including
LEGACY_VM_SUPPORThere?
Added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid uses of ?. in locations that are not Babeled, to help Firefox 68.12.0esr pass browser tests.