Skip to content

Warn about DWARF inhibiting binaryen opts only when binaryen optimizes #25889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+5 −4
Merged

Warn about DWARF inhibiting binaryen opts only when binaryen optimizes #25889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13406,8 +13406,9 @@ def test_wasm_worker_preprocessor_flags(self):
@parameterized({
# we will warn here since -O2 runs the optimizer and -g enables DWARF
'O2_g': (True, ['-O2', '-g']),
# asyncify will force wasm-opt to run as well, so we warn here too
'asyncify_g': (True, ['-sASYNCIFY', '-g']),
# asyncify will force wasm-opt to run as well, but without optimizations, so
# we do not warn about the lack of optimization
'asyncify_g': (False, ['-sASYNCIFY', '-g']),
# with --profiling-funcs however we do not use DWARF (we just emit the
# names section) and will not warn.
'O2_pfuncs': (False, ['-O2', '--profiling-funcs']),
Expand Down
2 changes: 1 addition & 1 deletion test/third_party/posixtestsuite
Open in desktop
Submodule posixtestsuite updated 5 files
+20 −0 conformance/interfaces/pthread_cancel/5-2.c
+13 −1 conformance/interfaces/pthread_cond_init/4-2.c
+11 −0 conformance/interfaces/pthread_kill/8-1.c
+12 −0 conformance/interfaces/pthread_mutex_init/5-3.c
+13 −1 conformance/interfaces/pthread_mutex_lock/3-1.c
2 changes: 1 addition & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2350,7 +2350,7 @@ def phase_binaryen(target, options, wasm_target):
intermediate_debug_info -= 1
# currently binaryen's DWARF support will limit some optimizations; warn on
# that. see https://github.com/emscripten-core/emscripten/issues/15269
if settings.GENERATE_DWARF:
if settings.GENERATE_DWARF and should_run_binaryen_optimizer():
diagnostics.warning('limited-postlink-optimizations', 'running limited binaryen optimizations because DWARF info requested (or indirectly required)')
with ToolchainProfiler.profile_block('wasm_opt'):
building.run_wasm_opt(wasm_target,
Expand Down