[contrib.glfw3] New version (bug fix + emscripten_html5_remove_event_listener use) #25972
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just pushed a new version with the following release notes:
glfwMakeContextCurrentnon-complianceemscripten_html5_remove_event_listenerwhich makes the library safer to use (it no longer iterferes with the client code). Note that the client should also useemscripten_html5_remove_event_listenerin order not to interfere with the library.@sbc100 This new version in particular contains the changes to use the newly introduced
emscripten_html5_remove_event_listener. The demo/test program has been updated to demonstrate that the library is doing the "right" thing, meaning NOT interfering with the handlers set by the client code and also removing all its handlers on exit (this is how I found out that there was an issue with one of the listeners setting 2 listeners for Safari).This is an output that demonstrates the test: