Fix test_embind_tsgen_memory64_pthread #26017
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this test was failing locally. This test was being skipped in CI because the `other` runner skips all wasm64 tests and the the `wasm64` runner it only runs `other.*_wasm64` tests. The `_emscripten_thread_mailbox_await` function unconditionally depends on `waitAsyncPolyfilled` to the symbol needs to at least always exist.
Collaborator
Author
|
Landing TBR since I'm in a different timezone and its a simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this test was failing locally. This test was being skipped in CI because the
otherrunner skips all wasm64 tests and the thewasm64runner it only runsother.*_wasm64tests.The
_emscripten_thread_mailbox_awaitfunction unconditionally depends onwaitAsyncPolyfilledto the symbol needs to at least always exist.