Prefix Node.js built-in imports with node:

[kleisauke]

To ensure compatibility with Deno which requires explicit
identification of built-in Node.js modules.

When targeting Node.js versions older than 16 (e.g.
-sMIN_NODE_VERSION=150000), the node: prefix is removed using
a custom Babel plugin.

[sbc100]

When you say "To ensure compatibility with To ensure compatibility with Deno and other runtimes that require
explicit identification..", when is it actually required? We do test our output on both deno and bun and they both seem to run the current output OK.

[sbc100]

Assuming there are some tests that fails under Deno or Bun prior to this change, could you add one or two of them to the list of tests we run under Bun:

emscripten/.circleci/config.yml

Line 887 in c9ade8c

test_targets: "core0.test_hello_world"

[kleisauke]

Here's a test case that currently fails on Deno:

$ emcc test/hello_world.c -sEXPORT_ES6 --extern-post-js test/modularize_post_js.js
$ deno a.out.js
error: Uncaught (in promise) TypeError: Import "module" not a dependency
    at file:///home/kleisauke/emscripten/a.out.js:83:42

  const { createRequire } = await import('module');
                            ^
    at async Module (file:///home/kleisauke/emscripten/a.out.js:83:29)
$ deno -v
deno 2.6.4

I thought Bun had the same behavior, but it appears to work correctly there. I'll revise the PR description accordingly.

[sbc100]

Oh, I thought we had some basic Deno testing but it looks like we only have that for Bun.

Would you mind adding some basic Deno testing as a separate PR, and then this change can increease the testing to include ES6.

The initial version #25947 has some Bun testing and I asked if @Macil would be interested in landing that separately, but maybe you want to do it @kleisauke?