Skip to content

Add some comments to emscripten_time.c. NFC#26285

Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:add_comments
Feb 17, 2026
Merged

Add some comments to emscripten_time.c. NFC#26285
sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100:add_comments

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Feb 17, 2026

As an internal detail we also skip defining the __ prefixed versions, since they are not used anywhere and not part of the musl impl either.

Landing this instead of #26284

@sbc100 sbc100 force-pushed the add_comments branch 3 times, most recently from a227fe2 to f21073a Compare February 17, 2026 21:06
@sbc100 sbc100 requested a review from kripken February 17, 2026 22:00
@sbc100 sbc100 enabled auto-merge (squash) February 17, 2026 22:00
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

@sbc100 sbc100 disabled auto-merge February 17, 2026 23:30
@sbc100 sbc100 merged commit 7e9b3ba into emscripten-core:main Feb 17, 2026
25 of 36 checks passed
@sbc100 sbc100 deleted the add_comments branch February 17, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants