Skip to content

Convert test_glerror to btest_exit. NFC #26348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Feb 27, 2026
Merged

Convert test_glerror to btest_exit. NFC #26348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions test/gl_error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
*/

#include <assert.h>
#include <emscripten.h>
#include <emscripten/html5.h>
#include <GL/gl.h>
#include <stdio.h>
#include <string.h>
Expand All @@ -21,10 +19,17 @@ int main() {
screen = SDL_SetVideoMode( 256, 256, 16, SDL_OPENGL );
assert(screen);

// pop from empty stack
// glGetError again should return 0 initially
assert(glGetError() == 0);

// pop from empty stack, causing an underflow error
glPopMatrix();
assert(glGetError() == GL_STACK_UNDERFLOW);
GLenum err = glGetError();
printf("glGetError -> %d\n", err);
assert(err == GL_STACK_UNDERFLOW);

// Calling glGetError again should report no error.
assert(glGetError() == 0);

REPORT_RESULT(1);
return 0;
}
2 changes: 1 addition & 1 deletion test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2218,7 +2218,7 @@ def test_perspective(self):

@requires_graphics_hardware
def test_glerror(self):
self.btest('gl_error.c', expected='1', cflags=['-sLEGACY_GL_EMULATION', '-lGL'])
self.btest_exit('gl_error.c', cflags=['-sLEGACY_GL_EMULATION', '-lGL'])

@parameterized({
'': ([],),
Expand Down