Remove stub flavor of wasm worker library. NFC#26429
Merged
Merged
Conversation
sbc100
force-pushed
the
remove_wasm_worker_stubs
branch
from
c4ad4f7 to
58fabc0
Compare
As far as I can tell there is no way to actually use this library since libwasm_workers is only ever included when `-sWASM_WORKERS` is used. Also, remove the addition of `-fPIC` (that is handled already by get_base_cflags); Also, remove the addition of `-DNDEBUG` (that is handled already by DebugLibrary).
sbc100
force-pushed
the
remove_wasm_worker_stubs
branch
from
58fabc0 to
483e4fa
Compare
kripken
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell there is no way to actually use this library since libwasm_workers is only ever included when
-sWASM_WORKERSis used. Given that it not active/usable I think we should remove it until there is demand for something like this.Also, remove the addition of
-fPIC(that is handled already by get_base_cflags);Also, remove the addition of
-DNDEBUG(that is handled already by DebugLibrary).