Move sleep slicing from musl's __wait to the lower level emscripten_futex_wait. NFC#26471
Open
sbc100 wants to merge 3 commits intoemscripten-core:mainfrom
Open
Move sleep slicing from musl's __wait to the lower level emscripten_futex_wait. NFC#26471sbc100 wants to merge 3 commits intoemscripten-core:mainfrom
__wait to the lower level emscripten_futex_wait. NFC#26471sbc100 wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of places we need to breaking up our
waitoperation. It also means that other users theemscripten_futex_waitAPI don't break pthread proxying or async cancellation.This change removes one more place where we were erroneously calling
pthread_self()in the Wasm Workers build of libc, so this change also makes the code less broken in the Wasm Worker case.Needed as part of #26487