Enable gettid() under WASM_WORKERS#26472
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Mar 18, 2026
Merged
Conversation
sbc100
force-pushed
the
wasm_worker_gettid
branch
from
276be6c to
c4c8966
Compare
sbc100
changed the title
gettid() under WASM_WORKERS
kripken
reviewed
Mar 17, 2026
sbc100
force-pushed
the
wasm_worker_gettid
branch
2 times, most recently
from
eba7750 to
1a4199a
Compare
sbc100
force-pushed
the
wasm_worker_gettid
branch
2 times, most recently
from
47145ef to
6e63248
Compare
Collaborator
Author
|
This is now rebased on top of #26472 , please review just the second commit. |
Member
|
Second commit lgtm |
Member
…f other MTLibrary libs). NFC This library gets linking into `-pthreads` build where wasm worker APIs are not available. If we have code in libc that looks like this it would fail to link in that case: ``` use_wasm_worker_api(); ``` The fact that this has worked thus far is only because we don't use that macro anywhere in libc today.
This change doesn't look very useful but as followup to this (and combined with emscripten-core#26468) this should allow us to enable more internal musl locking code that currently depends on `pthread_self()->tid`.
sbc100
force-pushed
the
wasm_worker_gettid
branch
from
6e63248 to
0cf0a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change doesn't look very useful but as followup to this (and combined with #26468) this should allow us to enable more internal musl locking code that currently depends on
pthread_self()->tid.