Use stdatomic in sbrk.c. NFC#26509
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 21, 2026
Merged
Conversation
Collaborator
Author
|
@google-labs-jules review this please |
dschuff
reviewed
Mar 20, 2026
| } | ||
|
|
||
| uintptr_t *sbrk_ptr = (uintptr_t*)emscripten_get_sbrk_ptr(); | ||
| _Atomic uintptr_t *sbrk_ptr = (_Atomic uintptr_t *)emscripten_get_sbrk_ptr(); |
Member
There was a problem hiding this comment.
So this works in nonthreaded mode because of how we downgrade atomics in the backend? or are c11 atomics specified to be regular loads in nonthreaded mode?
Collaborator
Author
There was a problem hiding this comment.
The atomics are lowered away to non-atomics in the backend.
dschuff
approved these changes
Mar 21, 2026
| } | ||
|
|
||
| uintptr_t *sbrk_ptr = (uintptr_t*)emscripten_get_sbrk_ptr(); | ||
| _Atomic uintptr_t *sbrk_ptr = (_Atomic uintptr_t *)emscripten_get_sbrk_ptr(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.