Simplify socket test harnesses. NFC#26679
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Simplify socket test harnesses. NFC#26679sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
requested review from
dschuff and
kripken
and removed request for
dschuff
kripken
reviewed
Apr 14, 2026
sbc100
force-pushed
the
cleanup_socket_tests
branch
from
2465efe to
d1e1649
Compare
Collaborator
Author
|
Oops, I accidentally landed these changes in #26680. I will send another PR with feedback. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 16, 2026
The changes from emscripten-core#26679 were mistakenly landed as part of emscripten-core#26680 This change applies the feedback from emscripten-core#26679
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.