Remove support for PTHREAD_PROCESS_SHARED locks, etc#26743
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 22, 2026
Merged
Remove support for PTHREAD_PROCESS_SHARED locks, etc#26743sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
process_shared
branch
2 times, most recently
from
ca74bc4 to
2e04ac6
Compare
sbc100
commented
Apr 21, 2026
| ((char *)next - sizeof(void *)) = &m->_m_next; | ||
| self->robust_list.head = &m->_m_next; | ||
| #ifndef __EMSCRIPTEN__ // XXX Emscripten does not support process-shared locks. | ||
| self->robust_list.pending = 0; |
Collaborator
Author
There was a problem hiding this comment.
@stephenduong1004 I think this line is where your crash is coming from.
Hopefully this change will fix it.
kripken
reviewed
Apr 21, 2026
kripken
reviewed
Apr 21, 2026
kripken
approved these changes
Apr 22, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Ok, I don't want to hold this up if it's urgently needed, but I do hope we can find a nicer solution that reduces the diff vs. musl
Collaborator
Author
Maybe I'll split out the wasm worker fix and keep this PR more focused. |
Emscripten does not support these. See emscripten-core#26733 for the start of this project.
sbc100
changed the title
Collaborator
Author
|
This change is now much more focused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten does not support these. See #26733 for the start of this project.