Remove redundant error checking from libpthread/libwasm_worker. NFC#26745
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 22, 2026
Merged
Remove redundant error checking from libpthread/libwasm_worker. NFC#26745sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
As the error states this limitation is already enforced by the feature matrix (using `Feature.WORKER_ES6_MODULES`). Duplicating the information already present in the feature matix kind of defeats the whole purpose of the feature matrix (i.e. a centralized place to store this info) and creates scope for skew. See emscripten-core#26677.
sbc100
changed the title
juj
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the error states, this limitation is already enforced by the feature matrix (using
Feature.WORKER_ES6_MODULES).Duplicating the information already present in the feature matix kind of defeats the whole purpose of the feature matrix (i.e. a centralized place to store this info) and creates scope for skew. See #26677.