Update comment regarding default safari version#26813
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 29, 2026
Merged
Update comment regarding default safari version#26813sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
kripken
approved these changes
Apr 29, 2026
| // Sur and iOS 14.5. | ||
| // The previous default, Safari 12.0.0 was released on September 17, 2018, | ||
| // bundled with macOS 10.14.0 Mojave. | ||
| // in MMmmVV, e.g. 160101 denotes Safari 16.1.1. |
Member
There was a problem hiding this comment.
Might as well make this example have the currently supported version, to avoid confusion?
Collaborator
Author
There was a problem hiding this comment.
Do you mean I should use the default version here?
Collaborator
Author
There was a problem hiding this comment.
I like including an example with minior numbers here.
Member
There was a problem hiding this comment.
Then perhaps something like x.y.z? I ask because I read this wrong the first time, I thought the example was the current version, especially as it appears first. I think an example equal to the current version, or newer, would be less confusing.
Anyhow, maybe it's just me. lgtm either way.
The minimum version was updated in emscripten-core#23312, but this comment was missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum version was updated in #23312, but this comment was missed.