Fix default setting of EXECUTABLE overriding the value set in phase_linker_setup() for autoconfiguring.

[juj]

Fix default setting of EXECUTABLE overriding the value set in phase_linker_setup() for autoconfiguring.

This line has no effect:

emscripten/tools/link.py

Lines 829 to 830 in 2a8234f

	# Add `#!` line to output JS and make it executable.
	settings.EXECUTABLE = config.NODE_JS[0]

since it was being overridden by default_setting('EXECUTABLE', 1), which looks only in user_settings, and not if the setting has already been initialized.

The result is that all autoconfigures would get the default shebang

emscripten/tools/link.py

Lines 460 to 462 in 2a8234f

	# By default, the resulting script will run under the version of node in the PATH.
	if settings.EXECUTABLE == 1:
	settings.EXECUTABLE = '/usr/bin/env node'

and attempt to run Node from PATH.

On my CI, I don't have a Node in PATH (exactly for the purposes of guarding against accidental 'wrong node' accesses like this). Fixes test_bullet_autoconf without Node in PATH: http://clbri.com:8010/api/v2/logs/406907/raw_inline

[sbc100]

So how does autoconf run the program if the resulting program has no #! line?

[sbc100]

I wonder if we should instead move the EMMAKEN_JUST_CONFIGURE block ~100 lines down so it comes after this?

If not maybe at least make this in to single if statement.

[sbc100]

This code is still part of phase_linker_setup (i know, its huge).

How about autoconf handling above may have initialized the EXECUTABLE ..

[juj]

Sounds good.

[juj]

It is not a case of the resulting program not having a #! line, but it is a case of the program having a line #! /usr/bin/env node, which searches node from PATH, which is not found.

When autoconfiguring, the code did first force EXECUTABLE to an absolute path to node, but that logic gets overridden by the later default_setting('EXECUTABLE', 1), force-reverting the shebang away from #! /absolute/path/to/node to that #!/usr/bin/env node, failing the code.