Minor pthread cleanups. NFC#26856
Merged
Merged
Conversation
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_pthreads.json: 26370 => 26370 [+0 bytes / +0.00%] Average change: +0.00% (+0.00% - +0.00%) ```
sbc100
reviewed
May 5, 2026
sbc100
approved these changes
May 5, 2026
sbc100
approved these changes
May 5, 2026
Collaborator
|
Thanks for all these recent changes! |
sbc100
approved these changes
May 6, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
in pthread_create.c, should the comment read "any allocation we do here should not be considered leaks" ?
Collaborator
Author
|
Good catch! Fixed with 3ea99f2. |
sbc100
reviewed
May 6, 2026
| void* restrict arg) { | ||
| // Note on LSAN: lsan intercepts/wraps calls to pthread_create so any | ||
| // allocation we do here should be considered leaks. | ||
| // allocation we do here should not be considered as leak. |
Collaborator
There was a problem hiding this comment.
The change from leaks -> as leak seems to make this less grammatically correct, doesn't it?
Maybe allocations should be plural?
allocations we do here should not be considered leaks ?
Collaborator
Author
There was a problem hiding this comment.
You're right, English isn't my first language. "considered as leak" sounded better to me, but it's actually incorrect.
Fixed with commit fee0b4f.
sbc100
approved these changes
May 6, 2026
sbc100
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #13007.