Skip to content

Fix infinite recursion in test browser.test_webgl_context_major_version.#26875

Merged
juj merged 1 commit intoemscripten-core:mainfrom
juj:fix_infinite_recursion_in_webgl_test
May 6, 2026
Merged

Fix infinite recursion in test browser.test_webgl_context_major_version.#26875
juj merged 1 commit intoemscripten-core:mainfrom
juj:fix_infinite_recursion_in_webgl_test

Conversation

@juj
Copy link
Copy Markdown
Collaborator

@juj juj commented May 6, 2026

Fix infinite recursion in test browser.test_webgl_context_major_version.

abort() calls to err(), and the test would overwrite err() to call to abort().

The test would pass, but only after throwing

[890/960] test_webgl_context_major_version (test_browser.browser64_4gb.test_webgl_context_major_version) ... JavaScript error: http://localhost:8888/test.js, line 193: InternalError: too much recursion
JavaScript error: http://localhost:8888/test.js, line 193: InternalError: too much recursion
JavaScript error: http://localhost:8888/test.js, line 193: InternalError: too much recursion
JavaScript error: http://localhost:8888/test.js, line 193: InternalError: too much recursion
ok

http://clbri.com:8010/api/v2/logs/420471/raw_inline

…on. abort() calls to err(), and the test would overwrite err() to call to abort().
@juj juj enabled auto-merge (squash) May 6, 2026 19:11
@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented May 6, 2026

Oh wow, that is bad.

This test should probably just a different mechanism here, but LGTM to the fix.

@juj juj disabled auto-merge May 6, 2026 20:50
@juj juj merged commit f8e5dd6 into emscripten-core:main May 6, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants