Remove extra_info argument from js_optimizer.py. NFC#26981
Merged
Conversation
This had no users. The only user of `run_on_file` is `run_js_optimizer` which doesn't pass this argument.
Collaborator
Author
|
The |
Member
|
We use js_optimizer passes to process the JS for metadce (before and after) and our own emscripten-specific JS optimizations, I think? |
kripken
approved these changes
May 20, 2026
Collaborator
Author
I think we use acorn_optimizer in all cases except wasm2js. IIUC wasm2js is the only user of |
Member
|
Oh, I forgot that distinction. Yes, maybe we can remove this, then. |
Member
|
(depending on how well the replacement performs, of course) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had no users. The only user of
run_on_fileisrun_js_optimizerwhich doesn't pass this argument.