Remove __syscall_pause#27044
Merged
Merged
Conversation
ccbcf3e to
179bbfb
Compare
kripken
reviewed
Jun 1, 2026
179bbfb to
34caee0
Compare
34caee0 to
1e561db
Compare
kripken
approved these changes
Jun 1, 2026
de20d3b to
57be8dc
Compare
57be8dc to
566782a
Compare
Collaborator
Author
|
I simplified this PR again so that pause now returns 0. I explained why I think that is OK in the PR description and we can followup with #27049 if we decide we prefer these functions to fail rather than lie about blocking. |
Member
|
I'm not opposed to this change, but let's mention it in the changelog? |
Collaborator
Author
Collaborator
Author
|
Let me phrase this as choice of two options that I'd like us to choose between for the next release:
|
Member
|
I feel I don't have enough of a sense of how user code uses this syscall to pick between them. So I don't feel strongly. But if we change a syscall or libc function, I think it's worth mentioning that breaking change. |
Collaborator
Author
sbc100
added a commit
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support this syscall and musl already has a fall back based on
poll/ppoll.Note that the return value for
pause()now changes to zero (from ENOSYS), because it is now based inpollinternally and currently our__syscall_pollimplementation returns zero when it would otherwise need to block. I have another change out the potentially change that (#27049) but we can consider that separately to this change.See #27036 and #27038