fix an FS trackingDelegate usage of err #7418
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and so invalidly used
sbc100
approved these changes
Oct 31, 2018
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
Which was also a local var, and so invalidly used. Instead, use console.log, consistently with the rest of the trackingDelegate code.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2026
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2026
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2026
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2026
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default. Also, add a test for this feature.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 29, 2026
Back in emscripten-core#7418 this message was updated, I believe in error. This logging is not related to `FS.trackingDelegate` and it not logging any kind of error. As a followup we should look at removing `logReadFiles` completely, or at least removing from `INCOMING_MODULE_JS_API` by default. Also, add a test for this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which was also a local var, and so invalidly used. Instead, use console.log, consistently with the rest of the trackingDelegate code.