Conversation
Collaborator
|
Great, thanks for working on this! |
sbc100
reviewed
Jun 19, 2019
| # tell binaryen to look at the features section, and if there isn't one, to use MVP | ||
| # (which matches what llvm+lld has given us) | ||
| cmd += ['--detect-features'] | ||
| if shared.Settings.DEBUG_LEVEL >= 2 or shared.Settings.PROFILING_FUNCS: |
Collaborator
There was a problem hiding this comment.
Should we find a way to make options available outside of emcc.py to avoid the need to all these extra settings in Settings.js?
Member
Author
There was a problem hiding this comment.
Perhaps. But a lot of the time we do need to use the new option inside the JS compiler too, and the settings.js mechanism is our current way to synchronize that world with python.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…-core#8724) To solve this, we emit -g on all intermediate operations on the wasm, preserving the function names. We then emit the symbol map at the very end, and also remove names from the binary if they are not needed there (doesn't make much sense to have names in both the binary and out, but we don't disallow that). Fixes emscripten-core#8686 Depends on WebAssembly/binaryen#2155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve this, we emit
-gon all intermediate operations on the wasm, preserving the function names. We then emit the symbol map at the very end, and also remove names from the binary if they are not needed there (doesn't make much sense to have names in both the binary and out, but we don't disallow that).Fixes #8686
Depends on WebAssembly/binaryen#2155