Skip to content

Use a response file if necessary in llvm opt invocation#8784

Merged
kripken merged 1 commit intoincomingfrom
opt_response_file
Jun 13, 2019
Merged

Use a response file if necessary in llvm opt invocation#8784
kripken merged 1 commit intoincomingfrom
opt_response_file

Conversation

@kripken
Copy link
Member

@kripken kripken commented Jun 12, 2019

No description provided.

@kripken
Copy link
Member Author

kripken commented Jun 12, 2019

Mailing list bug report has confirmed this fixes the issue. I'm not sure how to add a test for this, as I couldn't reproduce the issue myself locally, but the one-line fix is pretty trivial.

@kripken kripken requested a review from dschuff June 13, 2019 21:25
@kripken
Copy link
Member Author

kripken commented Jun 13, 2019

(Note btw that this is probably only useful for fastcomp, as we defer linking there and send potentially a long list of files into llvm opt.)

@kripken kripken merged commit 08d2df7 into incoming Jun 13, 2019
@kripken kripken deleted the opt_response_file branch June 13, 2019 23:07
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
…ore#8784)

On fastcomp we defer linking  and send potentially a long list of files into llvm opt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants