Rename Bullet's VERSION file #9034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoconf projects usually include the source root because they put configuration files there. Many of these contain files named VERSION. C++17 statndard libraries have a new <version> header. On case-insensitive filesystems, hilarity ensues.
Collaborator
|
But doesn't configure and other stuff rely on finding a file called VERSION here? Perhaps we could have instead just not copied that file (since the test code does a deep copy of this tree)? Or use a separate build tree? Then the root where config.h would not be source root but the build root? Anyway I guess its fixed now? |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Autoconf projects usually add the source root to the default #include path because they put configuration files there. Many of these contain files named VERSION. C++17 standard libraries have a new header. On case-insensitive filesystems, hilarity ensues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconf projects usually add the source root to the default #include path because they put
configuration files there. Many of these contain files named VERSION.
C++17 standard libraries have a new header.
On case-insensitive filesystems, hilarity ensues.