Use dwarf_to_json.wasm#9311
Closed
yurydelendik wants to merge 3 commits intoemscripten-core:masterfrom
Closed
Conversation
sbc100
reviewed
Aug 23, 2019
See yurydelendik/dwarf-to-json repo.
Member
|
I think instructions for where the Rust code is, and how to build it, would be enough. Checking in the wasm binary would be like how we check in the Java binary for Closure Compiler, as long as we know where the upstream is, that's fine. @yurydelendik can you please elaborate more on what is blocking this PR, I'm not sure I understood from your comment in the original issue? |
Collaborator
Author
there is a todo:
|
Collaborator
Author
|
binaryen supports DWARF nowadays -- closing in favor of that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #8948. It switches wasm-sourcemap.py to use nodejs (to run dwarf_to_json.wasm) that generates map/JSON. I tried to preserve all wasm-sourcemap.py's extra logic.
TODO is: fix rest of the toolset and testing to not rely or specify llvm-dwarfdump as wasm-sourcemap.py dependency.