Skip to content

Use dwarf_to_json.wasm#9311

Closed
yurydelendik wants to merge 3 commits intoemscripten-core:masterfrom
yurydelendik:dwarf_to_json
Closed

Use dwarf_to_json.wasm#9311
yurydelendik wants to merge 3 commits intoemscripten-core:masterfrom
yurydelendik:dwarf_to_json

Conversation

@yurydelendik
Copy link
Copy Markdown
Collaborator

Attempt to fix #8948. It switches wasm-sourcemap.py to use nodejs (to run dwarf_to_json.wasm) that generates map/JSON. I tried to preserve all wasm-sourcemap.py's extra logic.

TODO is: fix rest of the toolset and testing to not rely or specify llvm-dwarfdump as wasm-sourcemap.py dependency.

Comment thread tools/wasm-sourcemap.py Outdated
Comment thread tools/wasm-sourcemap.py Outdated
@kripken
Copy link
Copy Markdown
Member

kripken commented Oct 2, 2019

I think instructions for where the Rust code is, and how to build it, would be enough. Checking in the wasm binary would be like how we check in the Java binary for Closure Compiler, as long as we know where the upstream is, that's fine.

@yurydelendik can you please elaborate more on what is blocking this PR, I'm not sure I understood from your comment in the original issue?

@yurydelendik
Copy link
Copy Markdown
Collaborator Author

yurydelendik commented Oct 2, 2019

can you please elaborate more on what is blocking this PR, I'm not sure I understood from your comment in the original issue?

there is a todo:

@yurydelendik
Copy link
Copy Markdown
Collaborator Author

binaryen supports DWARF nowadays -- closing in favor of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm-sourcemaps.py is slow and memory inefficient

3 participants