Add support for reftypes for Binaryen's InstrumentLocals pass#9612
Merged
aheejin merged 2 commits intoemscripten-core:incomingfrom Oct 11, 2019
Merged
Add support for reftypes for Binaryen's InstrumentLocals pass#9612aheejin merged 2 commits intoemscripten-core:incomingfrom
aheejin merged 2 commits intoemscripten-core:incomingfrom
Conversation
This adds support for anyref and exnref types for Binaryen's InstrumentLocals pass. But at this point it is hard to add a test in emscripten side because `anyref` is not generated by C/C++ programs and `exnref` is used with exception handling feature, which has not been added. And anyway there are no tests for existing `get_` and `set_` functions for integer/float types in the emscripten side. Companion to WebAssembly/binaryen#2375.
Member
Author
|
Sorry, it's not ready yet. I'll post again when it's ready for review. |
Member
Author
|
I think it's ready. I thought it was not because of the |
kripken
approved these changes
Oct 10, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…pten-core#9612) This adds support for anyref and exnref types for Binaryen's InstrumentLocals pass. But at this point it is hard to add a test in emscripten side because `anyref` is not generated by C/C++ programs and `exnref` is used with exception handling feature, which has not been added. And anyway there are no tests for existing `get_` and `set_` functions for integer/float types in the emscripten side. Companion to WebAssembly/binaryen#2375.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for anyref and exnref types for Binaryen's
InstrumentLocals pass. But at this point it is hard to add a test in
emscripten side because
anyrefis not generated by C/C++ programs andexnrefis used with exception handling feature, which has not beenadded. And anyway there are no tests for existing
get_andset_functions for integer/float types in the emscripten side.
Companion to WebAssembly/binaryen#2375.