Re-allow -fPIC compiler flag during compilation#9750
Merged
Conversation
kripken
approved these changes
Nov 1, 2019
We were temporally disabling this flag due to issues with PIC code in static linking. These issues should not be resolved. Fixes: #9013
Collaborator
Author
|
The chrome failure is unrelated to this change so I'm landing with admin privs. |
sbc100
added a commit
that referenced
this pull request
Jan 14, 2020
This is a partial revert of #9750. The binaryen change that was designed to allow this to work was reverted: WebAssembly/binaryen#2513
sbc100
added a commit
that referenced
this pull request
Jan 14, 2020
This is a partial revert of #9750. The binaryen change that was designed to allow this to work was reverted: WebAssembly/binaryen#2513
sbc100
added a commit
that referenced
this pull request
Jan 15, 2020
This is a partial revert of #9750. The binaryen change that was designed to allow this to work was reverted: WebAssembly/binaryen#2513
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
We were temporally disabling this flag due to issues with PIC code in static linking. These issues should not be resolved. Fixes: emscripten-core#9013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were temporally disabling this flag due to issues with PIC code
in static linking. These issues should not be resolved.
Fixes: #9013