Vbat precision increment w resting voltage#159
Vbat precision increment w resting voltage#159tylercorleone wants to merge 14 commits intoemuflight:masterfrom
Conversation
(cherry picked from commit 9d5fb85)
…w_resting_voltage
…_w_resting_voltage
…_w_resting_voltage
…_w_resting_voltage
|
Note this line of code in OSD_AVG_CELL_VOLTAGE: I'm using this to see the difference between the "resting voltage" and the canonical one |
|
Clones removed
==============
+ src/main/cms/cms_menu_imu.c -1
+ src/main/cms/cms_menu_power.c -1
See the complete overview on Codacy |
|
yeah I think seperating these two things would be good to do. I'd also really like to see the compensated voltage (resting voltage) as something you can choose to show in the osd. That might become just what I use. |
|
@tylercorleone on a 'erased all' flashed fc i'm getting |
This branch wasn't updated with the revert of the "thrust linearization" that we made on the master. The vbat_precision increment is also on a dedicated branch: #161 Let me know if the problem is still there! |
|
@tylercorleone cool thanks going to merge that on my working copy ;) |
show/hide OSD items with expert-mode toggle
This PR contains the cherry-pick of this PR: https://github.com/betaflight/betaflight/pull/7255/commits
The branch containing only the changes needed to increment the battery precision (the above commits and other changes needed because of the conflicts) can be found here: https://github.com/tylercorleone/EmuFlight/tree/vbat_precision_increment
Here is contained also the implementation of "resting battery voltage", that is an attempt to compensate the sag caused by the spinning motors on battery voltage, e.g. on a punch, that is the scope of this https://github.com/emuflight/EmuFlight/projects/7
The vbat_max_voltage_sag parameter represents the maximum voltage sag the motors are capable of, e.g. 0.4V -> vbat_max_voltage_sag = 40
It is better to mantain this value BELOW the actual value in order to avoid to over-compensate. A conservative value of 0.2V has been chosen has default value.
The sag is simply calculated as the product of the maximum voltage sag and the "percent" of the motor output, actually the average normalized motor output (without the offset needed by the ESC protocol used).
It is better to separate the two concepts?
I think that a lot of testing and changes at the configurator are needed!