refactor: introduce IKasTransport seam and add wrapper-level client tests#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a transport seam so the action names and parameters the typed wrappers send are finally
unit-testable. Internal-only refactor — no public API change and no transport behaviour change.
Seam
IKasTransport(Soap/IKasTransport.cs) with the existingCallAsync(action, params, ct)signatureKasSoapTransportimplements it;KasClientnow depends onIKasTransportIKasTransportonto the sameKasSoapTransportsingleton (no second transport), so theshared session token and flood window are preserved
Tests (+52)
RecordingKasTransportfake (throws on empty queue → catches forgotten enqueues / extra calls)parameter dictionary, and the response mapping — incl. KAS quirks:
zone_hosttrailing-dot, apexrecord_name,record_aux,ddns_loginvsdyndns_login, Y/N + tri-state, scalar-id extractionRequestAsyncpassthrough (incl. token), DI single-instance invariantReview
Build / tests