Skip to content

Include woff2 static files#5694

Closed
ryanhiebert wants to merge 1 commit intoencode:masterfrom
ryanhiebert:manifest
Closed

Include woff2 static files#5694
ryanhiebert wants to merge 1 commit intoencode:masterfrom
ryanhiebert:manifest

Conversation

@ryanhiebert
Copy link
Copy Markdown
Contributor

The .woff2 fonts aren't being included in the release, and that's causing failures for my build using whitenoise.storage.CompressedManifestStaticFilesStorage, which looks for all referenced files from CSS files and compresses them with a static hash on the filename.

@ryanhiebert
Copy link
Copy Markdown
Contributor Author

3.7.3 For some reason did include woff2 in the PyPI releases, but 3.7.4 does not. I'm not sure what changed between those releases as far as deploy process, and it's possible that this won't fix it, depending on the cause. It still seems like it should be included in the manifest, though.

@ryanhiebert
Copy link
Copy Markdown
Contributor Author

I think that #5624 is the likely culprit, because before that the package data was given by a function in setup.py, rather than by looking at the MANIFEST.in. The woff2 file was the one that I was hitting, but I'm not yet sure that it's the only one that may have been lost by the change there.

@xordoquy
Copy link
Copy Markdown
Contributor

Indeed that was working by unexpected side effect :(
I will try to ensure there are no other files forgotten elsewhere with drf.

@xordoquy xordoquy added the Bug label Dec 21, 2017
@xordoquy
Copy link
Copy Markdown
Contributor

closes #5692

@axnsan12
Copy link
Copy Markdown
Contributor

*.ico seems to be missing too (static/rest_framework/docs/img/favicon.ico)

@lovelydinosaur lovelydinosaur added this to the Release 3.7.6 milestone Dec 21, 2017
@lovelydinosaur
Copy link
Copy Markdown
Contributor

Thanks @ryanhiebert, @axnsan12.

Versions 3.7.5 & 3.7.6 now released. 🙃

@lovelydinosaur
Copy link
Copy Markdown
Contributor

I think we're clear now, right?
Shout out if anything's still borked.

@ryanhiebert ryanhiebert deleted the manifest branch December 21, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants