Map httpcore transport close exceptions to httpx exceptions.#1606
Merged
Conversation
lovelydinosaur
added
the
user-experience
florimondmanca
approved these changes
Apr 29, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs specific comment here: https://github.com/encode/httpx/issues/1459#issuecomment-826834566
As it happens, I think we may well want to be removing
CloseErrorfrom being a thing in any case. If we have a non-graceful close we likely just want to mask that and continue on regardless. However, this mapping is clearly the right thing to do at this point in time.