Skip to content

Map httpcore transport close exceptions to httpx exceptions. #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 5 commits into from
Apr 29, 2021
Merged

Map httpcore transport close exceptions to httpx exceptions. #1606

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f04999
Update brotli support to use the brotlicffi package
lovelydinosaur Apr 28, 2021
6d2f501
Update tests to use brotlicffi package
lovelydinosaur Apr 28, 2021
60795c1
Update tests to use brotlicffi package
lovelydinosaur Apr 28, 2021
a034f10
Map httpcore exceptions on transport close
lovelydinosaur Apr 28, 2021
c56a2c6
Merge branch 'master' into map-transport-close-exceptions
lovelydinosaur Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions httpx/_transports/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ def __exit__(
exc_value: BaseException = None,
traceback: TracebackType = None,
) -> None:
self._pool.__exit__(exc_type, exc_value, traceback)
with map_httpcore_exceptions():
self._pool.__exit__(exc_type, exc_value, traceback)

def handle_request(
self,
Expand Down Expand Up @@ -256,7 +257,8 @@ async def __aexit__(
exc_value: BaseException = None,
traceback: TracebackType = None,
) -> None:
await self._pool.__aexit__(exc_type, exc_value, traceback)
with map_httpcore_exceptions():
await self._pool.__aexit__(exc_type, exc_value, traceback)

async def handle_async_request(
self,
Expand Down