fix: off by one error in gsoSplit on linux - #140
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an off-by-one bug in the Linux gsoSplit implementation so that, when the output buffer slice is exhausted, the function returns the correct “number of buffers populated” value (matching its documented contract). This aligns ErrTooManySegments behavior with how callers can safely use the returned count.
Changes:
- Adjust
gsoSplitoverflow return value fromi-1toito correctly report populated buffer count. - Add a regression test to validate the overflow behavior returns
len(out)populated buffers alongsideErrTooManySegments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| polyamide/tun/offload_linux.go | Fixes overflow count returned by gsoSplit to match the “buffers populated” contract. |
| polyamide/tun/offload_linux_test.go | Adds a targeted regression test ensuring overflow returns the populated count and ErrTooManySegments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WireGuard upstream seems to have an off-by-one error in the
gsoSplitfunction.A countercase would be if our outBuffs' size is 1.
Would return 0, while the fn is supposed to return "the number of buffers populated".