chore(rt-v1): flip shared orchestrator release_branches default to main#154
Merged
Merged
Conversation
Both build-php-v1.yaml and build-php-laravel.yaml had:
release_branches:
default: "stage,hotfix,rc"
That's RT v1 muscle memory — the list of branches mathieudutour treats
as release-emitting. Under RT v2, main is the only tag-emitting branch;
rt-* branches emit rc tags via encodium/actions _compute-rt-tag, not
mathieudutour.
Audit of all 8 Template A/laravel callers (accounts-api, catalog_api,
internal_api, license_api, listings-url-service, returns-api, rp_api,
vin_decoder_service) confirms every one explicitly overrides:
with:
release_branches: main
So the default is dead weight — nothing depends on it. Flipping to
'main' preserves current behavior and stops advertising a v1 concept
to any future caller.
pdodgen-revparts
marked this pull request as ready for review
July 10, 2026 21:27
PR SummaryLow Risk Overview That old default reflected RT v1 / mathieudutour behavior where those branches could emit releases. Existing Template A and Laravel callers already pass Reviewed by Cursor Bugbot for commit aff64f4. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
build-php-v1.yamlandbuild-php-laravel.yamlhadrelease_branchesdefault ofstage,hotfix,rc— RT v1 muscle memory (mathieudutour treats those branches as release-emitting).Every Template A / laravel caller (accounts-api, catalog_api, internal_api, license_api, listings-url-service, returns-api, rp_api, vin_decoder_service) explicitly overrides with
release_branches: main, so the default was dead weight. Flipping tomainpreserves current behavior (nobody depends on the old default) and stops advertising a v1 concept to future callers.