fix: await pipeTo to prevent upload UUID race condition - #16
Merged
Conversation
withTransform was calling pipeTo as fire-and-forget, so getUuid() could be called before the upload stream's start() (which calls initUpload and receives the UUID) had resolved.
Contributor
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withTransformcalledpipeTofire-and-forget, causing a race condition wheregetUuid()could be called beforeinitUploadresolvedpipeTopromise aspipeDoneso the caller can await the full pipe chain before reading the UUIDRoot cause
The upload stream's
start()method callsinitUpload(a network request) which sets the UUID. ButpipeTowas not awaited, sosealStreamcould complete andgetUuid()could run beforestart()finished — returning an empty string.Test plan