fix: first-class onTap for PDFView (#133) - #353
Conversation
gestureRecognizers + TapGestureRecognizer is unreliable on platform views. Report single taps from native AndroidPdfViewer / PDFKit via onTap instead.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review results (worker review-release-prs-353-357)Quality gates
Review notes
Merge + releaseMerged into |
Summary
PDFView.onTapcallback delivered from native (AndroidOnTapListener, iOS single-tap recognizer) so apps get reliable taps without fighting the platform-view gesture arena.gestureRecognizers+TapGestureRecognizeris unreliable; preferonTap. KeepgestureRecognizersfor parent-scroll conflicts (EagerGestureRecognizer).falsefromonTapso the event is not consumed).Fixes #133
Test plan
flutter pub get && dart format . && flutter analyze && flutter test(95 passed)scripts/run_android_unit_tests.sh) — all passedonLinkHandlerBase:
migrate/kotlin-swift(not main). No package version bump.