quest_004: Add .license files for AI-referenced assets, remove unused… - #2625
Merged
Merged
Conversation
…/duplicate images
There was a problem hiding this comment.
Pull request overview
Adds REUSE/asset licensing metadata for quest_004 assets (including AI-referenced art), and removes/rewires a handful of unused or duplicate quest-local images.
Changes:
- Added
.licensefiles for several quest_004 sprites and one audio asset to document provenance/licensing. - Removed quest-local image assets (and their
.importfiles) that are no longer intended to be used. - Updated quest_004 scenes to drop the removed conch shell reference and to use the shared third-party Rubber Duck asset path.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scenes/quests/lore_quests/quest_004/menhir/Sprite-0001.png.license | Adds SPDX/license metadata for the menhir sprite asset. |
| scenes/quests/lore_quests/quest_004/Cliff_Tiles-praderas.png.import | Removes import metadata for a removed tiles image. |
| scenes/quests/lore_quests/quest_004/Cliff_Tiles-praderas.png | Removes an unused quest-local image asset. |
| scenes/quests/lore_quests/quest_004/assets/willomena.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/strawman.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/sable-Sheet.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/Rubber duck.png.import | Removes import metadata for a removed quest-local duplicate asset. |
| scenes/quests/lore_quests/quest_004/assets/Rubber duck.png | Removes the quest-local Rubber Duck image (now referenced from shared third_party). |
| scenes/quests/lore_quests/quest_004/assets/noria-Sprites.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/noria-Sheet.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/menhir.png.license | Adds SPDX/license metadata for an AI-referenced asset. |
| scenes/quests/lore_quests/quest_004/assets/Concha_caracol.png.import | Removes import metadata for a removed quest-local image asset. |
| scenes/quests/lore_quests/quest_004/assets/Concha_caracol.png | Removes a quest-local conch shell image asset. |
| scenes/quests/lore_quests/quest_004/assets/audio/humEffect.wav.license | Adds SPDX/license metadata and source link for a third-party sound effect. |
| scenes/quests/lore_quests/quest_004/01_dream_threshold/norias_workshop.tscn | Removes the removed conch texture reference and related SpriteFrames content. |
| scenes/quests/lore_quests/quest_004/01_dream_threshold/mythical_meadows.tscn | Repoints Rubber Duck usage to the shared third-party asset and updates subresources accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
195
to
196
| [sub_resource type="SpriteFrames" id="SpriteFrames_carac"] | ||
| animations = [{ | ||
| "frames": [{ | ||
| "duration": 1.0, | ||
| "texture": ExtResource("17_carac") | ||
| }], | ||
| "loop": 1, | ||
| "name": &"default", | ||
| "speed": 5.0 | ||
| }] | ||
|
|
|
Play this branch at https://play.threadbare.game/branches/endlessm/fix/quest004-ai-asset-licensing/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/duplicate images