Use consistent "pop" in volume settings - #2685
Merged
Merged
Conversation
Manuel pointed out in review that it would be better to consistently use the same "pop" for every adjustment to more clearly hear the difference, and he's right: some pops are considerably quieter than others. Remove all except the loudest pop. Remove the pitch randomization which also made it harder to compare different volume levels. Finally remove the miaow, which I thought was funny but I can't really justify when removing it allows also removing the randomizer entirely. Now that we don't sometimes have the (long) cat noise playing, we can also reset the max polyphony on the player to 1: it is desirable to cut off the older pop to play a newer one each time the slider moves.
manuq
approved these changes
Aug 10, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
More accurate and more boring... sorry!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use consistent "pop" in volume settings
Manuel pointed out in review that it would be better to consistently use
the same "pop" for every adjustment to more clearly hear the difference,
and he's right: some pops are considerably quieter than others.
Remove all except the loudest pop. Remove the pitch randomization which
also made it harder to compare different volume levels. Finally remove
the miaow, which I thought was funny but I can't really justify when
removing it allows also removing the randomizer entirely.
Now that we don't sometimes have the (long) cat noise playing, we can
also reset the max polyphony on the player to 1: it is desirable to cut
off the older pop to play a newer one each time the slider moves.