Skip to content

Added signals for Skeleton NPC movement + dialogue across scenes - #2725

Merged
rencarle merged 2 commits into
intern_side_questfrom
lyn/dialogue-additions
Aug 17, 2026
Merged

Added signals for Skeleton NPC movement + dialogue across scenes#2725
rencarle merged 2 commits into
intern_side_questfrom
lyn/dialogue-additions

Conversation

@lynette023

Copy link
Copy Markdown

Revised version of previous commit: added dialogue for Boat, Jungle, Temple 1, Temple 2, and Treasure Room

Still having trouble with Temple Room 2, though the signal is there. @rencarle can you fix this on your next iteration as you add in your other work? Also added Skeleton NPC to the Treasure Room, but the ordering of the movement is off

Added all text except for the Beach. Renamed all existing dialogue components to follow consistent format across scenes.

Made minor adjustments to Temple 2 layout to add Skeleton NPC. Added Player Boat asset for intro scene.
… Room

Temple Room 2 still not working as intended - passing off to Renee for now (to fix next)

Also inserted dialogue for Treasure Room we can use or omit (hint and movement end dialogue)
@lynette023
lynette023 requested a review from rencarle August 17, 2026 18:23
@lynette023
lynette023 requested a review from a team as a code owner August 17, 2026 18:23
@lynette023 lynette023 moved this from Todo to In Progress in Threadbare SideQuest Aug 17, 2026
@lynette023 lynette023 linked an issue Aug 17, 2026 that may be closed by this pull request
6 tasks
@rencarle

Copy link
Copy Markdown

I noticed you made various functions that do that same thing for skeleton_movement script. It's fine, but I will delete them and connect them all back to the first function. Just for future reference, when connecting a signal you can click "Pick", select the node with the script you want to connect the signal to, and select the function you want.

@rencarle

Copy link
Copy Markdown

I noticed you made various functions that do that same thing for skeleton_movement script. It's fine, but I will delete them and connect them all back to the first function. Just for future reference, when connecting a signal you can click "Pick", select the node with the script you want to connect the signal to, and select the function you want.

This avoids making replica code (and makes maintainability easier).

@rencarle
rencarle merged commit 68eacc5 into intern_side_quest Aug 17, 2026
4 of 6 checks passed
@rencarle
rencarle deleted the lyn/dialogue-additions branch August 17, 2026 18:42
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Threadbare SideQuest Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add dialogue boxes for every scene

2 participants