ci: add presubmit GitHub Actions workflow - #33
Merged
Conversation
Lints bash (shellcheck + bash -n), PowerShell (parser + PSScriptAnalyzer), and data files (JSON/TOML/mobileconfig), lints the workflows themselves with actionlint, smoke-tests both package-firewall generators with dummy credentials, and runs the package-firewall test suites on ubuntu/macos/ windows once package-firewall/tests/ lands on a branch. Also fixes the one shellcheck finding (SC1007 in render.sh) so the lint gate starts green.
|
Note Great work! All the policy violations detected earlier were successfully resolved. |
shrey-endor
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a presubmit CI workflow (
.github/workflows/ci.yml) that runs on every pull request and on pushes tomain:shellcheck --severity=warningon all hand-written scripts (generator, lib, templates, agent-governance), plusbash -non everything including the generated examples underout/(excluded from full shellcheck because they intentionally define config blocks not every script consumes)..ps1(including{{TOKEN}}templates and generated output), plus PSScriptAnalyzer on hand-written scripts gating on Error severity (warnings printed, non-blocking).jqfor JSON,tomllibfor TOML,xmllintfor the.mobileconfigplists.runblocks).package-firewall/tests/run-all.shon ubuntu + macos andrun-all.ps1on windows. The tests directory is on an unmerged branch, so these jobs log a skip notice until it lands, then activate automatically.Also fixes the single pre-existing shellcheck finding (SC1007 in
agent-governance/scripts/render.sh:CDPATH= cd→CDPATH='' cd, equivalent) so the lint gate starts green.All jobs were run locally before pushing: shellcheck/bash -n/actionlint clean, all .ps1 parse, PSScriptAnalyzer 0 errors (137 non-blocking warnings, mostly PSAvoidUsingWriteHost), JSON/TOML/mobileconfig valid, both generator smoke tests pass.